From c2fc9ecf6878b77c9f3473b30bf487bf3b1ef398 Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Sat, 9 Apr 2016 16:04:07 +0200
Subject: [PATCH] Fix scrutinizer warning

---
 htdocs/admin/tools/index.php               | 2 +-
 htdocs/comm/propal/stats/index.php         | 2 +-
 htdocs/fourn/class/paiementfourn.class.php | 2 +-
 htdocs/holiday/card.php                    | 2 +-
 htdocs/holiday/define_holiday.php          | 2 +-
 htdocs/holiday/list.php                    | 2 +-
 htdocs/holiday/view_log.php                | 2 +-
 htdocs/hrm/hrm.php                         | 2 +-
 htdocs/product/class/product.class.php     | 6 +++---
 9 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/htdocs/admin/tools/index.php b/htdocs/admin/tools/index.php
index 9b08054beac..8da041d05da 100644
--- a/htdocs/admin/tools/index.php
+++ b/htdocs/admin/tools/index.php
@@ -40,7 +40,7 @@ $form = new Form($db);
 $title=$langs->trans("SystemToolsArea");
 if (GETPOST('leftmenu') == 'admintools') $title=$langs->trans("ModulesSystemTools");
 
-llxHeader(array(),$title);
+llxHeader('', $title);
 
 print load_fiche_titre($title,'','title_setup');
 
diff --git a/htdocs/comm/propal/stats/index.php b/htdocs/comm/propal/stats/index.php
index 2c93f874baa..33895c2ac54 100644
--- a/htdocs/comm/propal/stats/index.php
+++ b/htdocs/comm/propal/stats/index.php
@@ -178,7 +178,7 @@ if (! $mesg)
     $px2->draw($filenameamount,$fileurlamount);
 }
 
-$data = $stats->getAverageByMonthWithPrevYear($endyear, $startyear, $filter);
+$data = $stats->getAverageByMonthWithPrevYear($endyear, $startyear);
 
 $fileurl_avg='';
 if (!$user->rights->societe->client->voir || $user->societe_id)
diff --git a/htdocs/fourn/class/paiementfourn.class.php b/htdocs/fourn/class/paiementfourn.class.php
index 940de150765..78bdab0f6c5 100644
--- a/htdocs/fourn/class/paiementfourn.class.php
+++ b/htdocs/fourn/class/paiementfourn.class.php
@@ -314,7 +314,7 @@ class PaiementFourn extends Paiement
 		// Si c'est le cas, on refuse le delete
 		if ($bank_line_id)
 		{
-			$accline = new AccountLine($this->db,$bank_line_id);
+			$accline = new AccountLine($this->db);
 			$accline->fetch($bank_line_id);
 			if ($accline->rappro)
 			{
diff --git a/htdocs/holiday/card.php b/htdocs/holiday/card.php
index 8cae9592033..66941d3ded7 100644
--- a/htdocs/holiday/card.php
+++ b/htdocs/holiday/card.php
@@ -677,7 +677,7 @@ $cp = new Holiday($db);
 
 $listhalfday=array('morning'=>$langs->trans("Morning"),"afternoon"=>$langs->trans("Afternoon"));
 
-llxHeader(array(),$langs->trans('CPTitreMenu'));
+llxHeader('', $langs->trans('CPTitreMenu'));
 
 if (empty($id) || $action == 'add' || $action == 'request' || $action == 'create')
 {
diff --git a/htdocs/holiday/define_holiday.php b/htdocs/holiday/define_holiday.php
index 71d456f8e16..52876b1d1cd 100644
--- a/htdocs/holiday/define_holiday.php
+++ b/htdocs/holiday/define_holiday.php
@@ -155,7 +155,7 @@ elseif($action == 'add_event')
 $form = new Form($db);
 $userstatic=new User($db);
 
-llxHeader(array(),$langs->trans('CPTitreMenu'));
+llxHeader('', $langs->trans('CPTitreMenu'));
 
 print load_fiche_titre($langs->trans('MenuConfCP'), '', 'title_hrm.png');
 
diff --git a/htdocs/holiday/list.php b/htdocs/holiday/list.php
index 46883f11a26..c7bc669535f 100644
--- a/htdocs/holiday/list.php
+++ b/htdocs/holiday/list.php
@@ -114,7 +114,7 @@ $max_year = 5;
 $min_year = 10;
 $filter='';
 
-llxHeader(array(),$langs->trans('CPTitreMenu'));
+llxHeader('', $langs->trans('CPTitreMenu'));
 
 $order = $db->order($sortfield,$sortorder).$db->plimit($limit + 1, $offset);
 
diff --git a/htdocs/holiday/view_log.php b/htdocs/holiday/view_log.php
index cf1bdcb8748..a9fe469c0cf 100644
--- a/htdocs/holiday/view_log.php
+++ b/htdocs/holiday/view_log.php
@@ -50,7 +50,7 @@ $langs->load('users');
 
 $cp = new Holiday($db);
 
-llxHeader(array(),$langs->trans('CPTitreMenu').' ('.$langs->trans("Year").' '.$year.')');
+llxHeader('', $langs->trans('CPTitreMenu').' ('.$langs->trans("Year").' '.$year.')');
 
 // Recent changes are more important than old changes
 $log_holiday = $cp->fetchLog('ORDER BY cpl.rowid DESC', " AND date_action BETWEEN '".$db->idate(dol_get_first_day($year,1,1))."' AND '".$db->idate(dol_get_last_day($year,12,1))."'");	// Load $cp->logs
diff --git a/htdocs/hrm/hrm.php b/htdocs/hrm/hrm.php
index daef4feef45..2a23c7e19c9 100644
--- a/htdocs/hrm/hrm.php
+++ b/htdocs/hrm/hrm.php
@@ -65,7 +65,7 @@ $holidaystatic=new Holiday($db);
 $childids = $user->getAllChildIds();
 $childids[]=$user->id;
 
-llxHeader(array(),$langs->trans('HRMArea'));
+llxHeader('', $langs->trans('HRMArea'));
 
 print load_fiche_titre($langs->trans("HRMArea"),'', 'title_hrm.png');
 
diff --git a/htdocs/product/class/product.class.php b/htdocs/product/class/product.class.php
index e9af15bb27e..499fd8c3694 100644
--- a/htdocs/product/class/product.class.php
+++ b/htdocs/product/class/product.class.php
@@ -3540,7 +3540,7 @@ class Product extends CommonObject
 			$handle=opendir($dir_osencoded);
 			if (is_resource($handle))
 			{
-			    while (($file = readdir($handle)) != false)
+			    while (($file = readdir($handle)) !== false)
     			{
     				if (! utf8_check($file)) $file=utf8_encode($file);	// To be sure data is stored in UTF8 in memory
     				if (dol_is_file($dir.$file)) return true;
@@ -3598,7 +3598,7 @@ class Product extends CommonObject
 			$handle=opendir($dir_osencoded);
             if (is_resource($handle))
             {
-    			while (($file = readdir($handle)) != false)
+    			while (($file = readdir($handle)) !== false)
     			{
     				$photo='';
 
@@ -3744,7 +3744,7 @@ class Product extends CommonObject
 		$handle=@opendir($dir_osencoded);
 		if (is_resource($handle))
 		{
-			while (($file = readdir($handle)) != false)
+			while (($file = readdir($handle)) !== false)
 			{
 				if (! utf8_check($file)) $file=utf8_encode($file);	// readdir returns ISO
 				if (dol_is_file($dir.$file) && preg_match('/('.$this->regeximgext.')$/i', $dir.$file))
-- 
GitLab