diff --git a/htdocs/lib/functions.lib.php b/htdocs/lib/functions.lib.php index 61a6bd7bf4079829c99d4e7c79f158beb4f456a4..b35458fe14b0051b8459a7e71bdaad9bfd45cfc9 100644 --- a/htdocs/lib/functions.lib.php +++ b/htdocs/lib/functions.lib.php @@ -40,11 +40,15 @@ if (! defined('ADODB_DATE_VERSION')) include_once(DOL_DOCUMENT_ROOT."/includes/a /** * Return value of a param into get or post variable * @param paramname Name of parameter to found + * @param length Length of string (security) * @return string Value found */ -function GETPOST($paramname) +function GETPOST($paramname,$length=0) { - return isset($_GET[$paramname])?$_GET[$paramname]:(isset($_POST[$paramname])?$_POST[$paramname]:''); + $out = isset($_GET[$paramname])?$_GET[$paramname]:(isset($_POST[$paramname])?$_POST[$paramname]:''); + $out = trim($out); + if ($length > 0 && strlen($out) > $length) $out=''; + return $out; } /** diff --git a/htdocs/product/liste.php b/htdocs/product/liste.php index b93338763b55c535fe85d3fd4bda3790b8e6efb0..7415e0c4b50d8928643f5a25ddfe7d123b81c84a 100644 --- a/htdocs/product/liste.php +++ b/htdocs/product/liste.php @@ -33,22 +33,15 @@ if ($conf->categorie->enabled) require_once(DOL_DOCUMENT_ROOT."/categories/class $langs->load("products"); $langs->load("stocks"); -$type=trim(isset($_GET["type"])?$_GET["type"]:$_POST["type"]); -$sref=isset($_GET["sref"])?$_GET["sref"]:$_POST["sref"]; - -$sbarcode=isset($_GET["sbarcode"])?$_GET["sbarcode"]:$_POST["sbarcode"]; -$snom=isset($_GET["snom"])?$_GET["snom"]:$_POST["snom"]; -$sall=isset($_GET["sall"])?$_GET["sall"]:$_POST["sall"]; -$type=isset($_GET["type"])?$_GET["type"]:$_POST["type"]; -$sref=trim($sref); -$sbarcode=trim($sbarcode); -$snom=trim($snom); -$sall=trim($sall); -$type=trim($type); - - -$sortfield = isset($_GET["sortfield"])?$_GET["sortfield"]:$_POST["sortfield"]; -$sortorder = isset($_GET["sortorder"])?$_GET["sortorder"]:$_POST["sortorder"]; +$sref=GETPOST("sref"); +$sbarcode=GETPOST("sbarcode"); +$snom=GETPOST("snom"); +$sall=GETPOST("sall"); +$type=GETPOST("type",1); + + +$sortfield = GETPOST("sortfield"); +$sortorder = GETPOST("sortorder"); if (! $sortfield) $sortfield="p.ref"; if (! $sortorder) $sortorder="ASC"; $page = $_GET["page"];