From 263b307579e5b949b7d02ec601e8b8ba97c9331f Mon Sep 17 00:00:00 2001
From: Tim Molter <tim.molter@gmail.com>
Date: Sat, 26 Apr 2014 13:33:05 +0200
Subject: [PATCH] bug fix in calculating min max - the min was set to
Double.MIN and it should have been -Double.MAX
---
.../com/xeiam/xchart/demo/charts/scatter/ScatterChart01.java | 2 +-
xchart/src/main/java/com/xeiam/xchart/Series.java | 5 ++---
.../main/java/com/xeiam/xchart/internal/chartpart/Axis.java | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/xchart-demo/src/main/java/com/xeiam/xchart/demo/charts/scatter/ScatterChart01.java b/xchart-demo/src/main/java/com/xeiam/xchart/demo/charts/scatter/ScatterChart01.java
index 04b51cfe..61dda398 100644
--- a/xchart-demo/src/main/java/com/xeiam/xchart/demo/charts/scatter/ScatterChart01.java
+++ b/xchart-demo/src/main/java/com/xeiam/xchart/demo/charts/scatter/ScatterChart01.java
@@ -53,7 +53,7 @@ public class ScatterChart01 implements ExampleChart {
int size = 1000;
for (int i = 0; i < size; i++) {
xData.add(random.nextGaussian());
- yData.add(-100 + random.nextGaussian());
+ yData.add(-1000000 + random.nextGaussian());
}
// Create Chart
diff --git a/xchart/src/main/java/com/xeiam/xchart/Series.java b/xchart/src/main/java/com/xeiam/xchart/Series.java
index 28572030..3b0c2acb 100644
--- a/xchart/src/main/java/com/xeiam/xchart/Series.java
+++ b/xchart/src/main/java/com/xeiam/xchart/Series.java
@@ -107,7 +107,7 @@ public class Series {
private double[] findMinMax(Collection<?> data, AxisType axisType) {
double min = Double.MAX_VALUE;
- double max = Double.MIN_VALUE;
+ double max = -Double.MAX_VALUE;
for (Object dataPoint : data) {
@@ -119,7 +119,6 @@ public class Series {
if (axisType == AxisType.Number) {
value = ((Number) dataPoint).doubleValue();
-
}
else if (axisType == AxisType.Date) {
Date date = (Date) dataPoint;
@@ -148,7 +147,7 @@ public class Series {
private double[] findMinMaxWithErrorBars(Collection<? extends Number> data, Collection<? extends Number> errorBars) {
double min = Double.MAX_VALUE;
- double max = Double.MIN_VALUE;
+ double max = -Double.MAX_VALUE;
Iterator<? extends Number> itr = data.iterator();
Iterator<? extends Number> ebItr = errorBars.iterator();
diff --git a/xchart/src/main/java/com/xeiam/xchart/internal/chartpart/Axis.java b/xchart/src/main/java/com/xeiam/xchart/internal/chartpart/Axis.java
index 6c79c5f7..fa809573 100644
--- a/xchart/src/main/java/com/xeiam/xchart/internal/chartpart/Axis.java
+++ b/xchart/src/main/java/com/xeiam/xchart/internal/chartpart/Axis.java
@@ -89,7 +89,7 @@ public class Axis implements ChartPart {
void resetMinMax() {
min = Double.MAX_VALUE;
- max = Double.MIN_VALUE;
+ max = -Double.MAX_VALUE;
}
/**
--
GitLab