diff --git a/test_create_movie.py b/test_create_movie.py index 6a66ce19f747f73ced63a738bd7f4c50cf7b2712..eebc9cbb654526ded249285e5407aaae22abe887 100644 --- a/test_create_movie.py +++ b/test_create_movie.py @@ -6,13 +6,12 @@ from main import MoviesApp class TestCreateMovie(TestCase): - def test_create_movie_inserts_movies_weak(self): + def test_create_movie_does_not_crash(self): url = MovieDatabase.construct_in_memory_url() movie_database = MovieDatabase(url) movie_database.ensure_tables_exist() session = movie_database.create_session() MoviesApp._create_movie(session, 'Example', 4000000, 290000000) - actual = session.query(Movie).filter(Movie.title == 'Example').one() # implicit oracle def test_create_movie_inserts_movies(self): @@ -22,7 +21,7 @@ class TestCreateMovie(TestCase): session = movie_database.create_session() MoviesApp._create_movie(session, 'Example', 4000000, 290000000) actual = session.query(Movie).filter(Movie.title == 'Example').one() - self.assertIsNotNone(actual) # not as weak oracle (but still weak) + self.assertIsNotNone(actual) # not as weak oracle (but still weak) def test_create_movie_inserts_one_movie(self): url = MovieDatabase.construct_in_memory_url() @@ -31,7 +30,7 @@ class TestCreateMovie(TestCase): session = movie_database.create_session() MoviesApp._create_movie(session, 'Example', 4000000, 290000000) actual = session.query(Movie).filter(Movie.title == 'Example').count() - self.assertEqual(actual, 1) # weak oracle + self.assertEqual(actual, 1) # weak oracle def test_create_movie_inserts_correct_dollar_figures(self): url = MovieDatabase.construct_in_memory_url() @@ -41,4 +40,4 @@ class TestCreateMovie(TestCase): MoviesApp._create_movie(session, 'Example', 4000000, 290000000) actual = session.query(Movie).filter(Movie.title == 'Example').one() self.assertEqual(actual.budget, 4000000) - self.assertEqual(actual.gross_revenue, 290000000) # better + self.assertEqual(actual.gross_revenue, 290000000) # better