Add a check on Requests_ApprovalChainModel::consider() to be sure we aren't...

Add a check on Requests_ApprovalChainModel::consider() to be sure we aren't considering any completed requsets.

application/modules/requests/models/ApprovalChainModel.php

@@ -202,6 +202,18 @@ class Requests_ApprovalChainModel extends Unl_Model
         if (count($requests) == 0) {
             return;
         }
+    
+        // If any advanced requests are completed, drop them from our list
+        foreach ($requests as $requestId => $request) {
+            if ($request->isComplete()) {
+                unset($requests[$requestId]);
+            }
+        }
+
+        // If we don't have any requests left to process (after dropping completed requsets), stop.
+        if (count($requests) == 0) {
+            return;
+        }
 
         // Find requests which haven't yet started (stack pointer = null and complete = no)
         $requestsToInit = new Unl_Model_Collection('Requests_RequestModel');