Skip to content
Snippets Groups Projects
Commit c4a25fca authored by Tim Steiner's avatar Tim Steiner
Browse files

When multiple requests are completed in the same HTTP request, they won't try...

When multiple requests are completed in the same HTTP request, they won't try to start back up the chain again.
parent 7963b464
No related branches found
No related tags found
No related merge requests found
......@@ -204,11 +204,14 @@ class Requests_ApprovalChainModel extends Unl_Model
}
// If any advanced requests are completed, drop them from our list
$incompleteRequests = new Unl_Model_Collection('Requests_RequestModel');
foreach ($requests as $requestId => $request) {
if ($request->isComplete()) {
unset($requests[$requestId]);
continue;
}
$incompleteRequests[$requestId] = $request;
}
$requests = $incompleteRequests;
// If we don't have any requests left to process (after dropping completed requests), stop.
if (count($requests) == 0) {
......@@ -238,11 +241,14 @@ class Requests_ApprovalChainModel extends Unl_Model
self::advance($requestsToAdvance);
// If any advanced requests were completed, drop them from our list
$incompleteRequests = new Unl_Model_Collection('Requests_RequestModel');
foreach ($requests as $requestId => $request) {
if ($request->isComplete()) {
unset($requests[$requestId]);
continue;
}
$incompleteRequests[$requestId] = $request;
}
$requests = $incompleteRequests;
// If we don't have any requests left to process (after dropping completed requests), stop.
if (count($requests) == 0) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment