Implement DCF Tabs
Can test on search-test.unl.edu:
- https://search-test.unl.edu/?q=harper
- https://search-test.unl.edu/?embed=5.0&q=harper
- https://search-test.unl.edu/?embed=5.0&u=http%3A%2F%2Fbusiness.unl.edu%2F&q=harper
- https://search-test.unl.edu/?embed=1&q=harper
- https://search-test.unl.edu/?embed=1&u=http%3A%2F%2Fbusiness.unl.edu%2F&q=harper
Verify if resolves this issue: #8 (closed)
Merge request reports
Activity
assigned to @rdee2
assigned to @erasmussen2 and unassigned @rdee2
assigned to @rdee2 and unassigned @erasmussen2
1 1 <?php if (!$isEmbed): ?><div class="dcf-bleed dcf-mb-0 dcf-overflow-y-auto"><?php endif ?> 2 2 3 <section class="dcf-wrapper dcf-grid dcf-col-gap-vw dcf-pt-9 dcf-txt-xs unl-font-sans unl-search-results" id="search_wrapper"> 3 <section class="dcf-wrapper dcf-grid dcf-col-gap-6 dcf-row-gap-9 dcf-pt-9 dcf-txt-xs unl-font-sans unl-search-results" id="search_wrapper"> changed this line in version 7 of the diff
30 )) ?> 31 </div> 32 <?php endif; ?> 33 </div> 23 34 24 <div class="dcf-col-100% dcf-col-33%-end@sm dcf-col-50%-end@lg dcf-pb-10 results-group" id="directory_results"> 25 <div class="result-head"> 26 <h2>Directory Results</h2> 27 <ul class="dcf-d-flex dcf-list-bare result-tab"> 28 <li><a href="#">People</a></li> 29 <li><a href="#">Departments</a></li> 30 </ul> 31 </div> 32 <div id="ppl_results" class="search-results"></div> 33 </div> 35 <div class="dcf-col-100% dcf-col-33%-end@md dcf-col-50%-end@lg dcf-pb-10 results-group" id="directory_results"> changed this line in version 7 of the diff
10 <li><a href="#local-results-container">This Site</a></li> 11 <li><a href="#unl-results-container">All of UNL</a></li> 12 </ul> 13 <div id="local-results-container"> 14 <?php echo $local_results ?> 15 </div> 16 <div id="unl-results-container"> 17 <?php echo renderTemplate('templates/5.0/google-results.tpl.php', array( 18 'title' => 'All of UNL', 19 'id' => 'unl_results' 20 )) ?> 21 </div> 22 </div> 23 <?php else: ?> 24 <h2>Web Results</h2> 25 <span class="dcf-d-inline-block dcf-txt-sm dcf-pt-4 dcf-pr-5 dcf-pb-4 dcf-pl-5 dcf-bg-white dcf-b-1 dcf-bb-0 dcf-b-solid unl-b-light-gray search-faux-tab">All of UNL</span> changed this line in version 7 of the diff
-
I'm not sure why business.unl.edu doesn't produce the unit tab.
-
Can we hide the line "Web Application Results" on the "This site" tab? https://search-test.unl.edu/?embed=5.0&u=http%3A%2F%2Fextension.unl.edu%2F&q=harper
-
@rdee2 Do we want
dcf-sr-only
on the<h3>
for google search results that Eric want to hide (from comment above). The current search hasdisplay:none
in search.css but the markup changes broke that.10 <li><a href="#local-results-container">This Site</a></li> 11 <li><a href="#unl-results-container">All of UNL</a></li> 12 </ul> 13 <div id="local-results-container"> 14 <?php echo $local_results ?> 15 </div> 16 <div id="unl-results-container"> 17 <?php echo renderTemplate('templates/5.0/google-results.tpl.php', array( 18 'title' => 'All of UNL', 19 'id' => 'unl_results' 20 )) ?> 21 </div> 22 </div> 23 <?php else: ?> 24 <h2>Web Results</h2> 25 <span class="dcf-bold dcf-d-inline-block dcf-txt-sm dcf-pt-4 dcf-pr-5 dcf-pb-4 dcf-pl-5 dcf-bg-white dcf-b-1 dcf-bb-0 dcf-b-solid unl-b-light-gray search-faux-tab">All of UNL</span> changed this line in version 8 of the diff
13 <div id="local-results-container"> 14 <?php if (isset($localTitle)): ?> 15 <h3 class="dcf-mb-0 dcf-mt-1"><?php echo $localTitle ?> Results</h3> 16 <?php endif; ?> 17 <?php echo $local_results ?> 18 </div> 19 <div id="unl-results-container"> 20 <h3 class="dcf-mb-0 dcf-mt-1">All of UNL Results</h3> 21 <?php echo renderTemplate('templates/5.0/google-results.tpl.php', array( 22 'id' => 'unl_results' 23 )) ?> 24 </div> 25 </div> 26 <?php else: ?> 27 <h2>Web Results</h2> 28 <h3 class="dcf-bold dcf-d-inline-block dcf-txt-sm dcf-mt-0 dcf-pt-4 dcf-pr-5 dcf-pb-4 dcf-pl-5 dcf-bg-white dcf-b-1 dcf-bb-0 dcf-b-solid unl-b-light-gray search-faux-tab">All of UNL</h3> changed this line in version 11 of the diff
18 'title' => 'All of UNL', 19 'id' => 'unl_results', 20 )) ?> 21 </div> 22 </div> 5 <div class="dcf-col-100% dcf-col-67%-start@md dcf-col-50%-start@lg results-group" id="search_results"> 6 <?php if (!empty($local_results)): ?> 7 <div class="dcf-tabs"> 8 <h2>Web Results</h2> 9 <ul> 10 <li><a href="#local-results-container">This Site</a></li> 11 <li><a href="#unl-results-container">All of UNL</a></li> 12 </ul> 13 <div id="local-results-container"> 14 <?php if (isset($localTitle)): ?> 15 <h3 class="dcf-mb-0 dcf-mt-1"><?php echo $localTitle ?> Results</h3> changed this line in version 10 of the diff
5 <div class="dcf-col-100% dcf-col-67%-start@md dcf-col-50%-start@lg results-group" id="search_results"> 6 <?php if (!empty($local_results)): ?> 7 <div class="dcf-tabs"> 8 <h2>Web Results</h2> 9 <ul> 10 <li><a href="#local-results-container">This Site</a></li> 11 <li><a href="#unl-results-container">All of UNL</a></li> 12 </ul> 13 <div id="local-results-container"> 14 <?php if (isset($localTitle)): ?> 15 <h3 class="dcf-mb-0 dcf-mt-1"><?php echo $localTitle ?> Results</h3> 16 <?php endif; ?> 17 <?php echo $local_results ?> 18 </div> 19 <div id="unl-results-container"> 20 <h3 class="dcf-mb-0 dcf-mt-1">All of UNL Results</h3> changed this line in version 10 of the diff
23 37 24 <div class="dcf-col-100% dcf-col-33%-end@sm dcf-col-50%-end@lg dcf-pb-10 results-group" id="directory_results"> 25 <div class="result-head"> 26 <h2>Directory Results</h2> 27 <ul class="dcf-d-flex dcf-list-bare result-tab"> 28 <li><a href="#">People</a></li> 29 <li><a href="#">Departments</a></li> 30 </ul> 31 </div> 32 <div id="ppl_results" class="search-results"></div> 33 </div> 38 <div class="dcf-col-100% dcf-col-33%-end@md dcf-col-50%-end@lg results-group" id="directory_results"> 39 <div class="dcf-tabs"> 40 <h2>Directory Results</h2> 41 <ul> 42 <li><a href="#people_results">People</a></li> changed this line in version 12 of the diff
26 <h2>Directory Results</h2> 27 <ul class="dcf-d-flex dcf-list-bare result-tab"> 28 <li><a href="#">People</a></li> 29 <li><a href="#">Departments</a></li> 30 </ul> 31 </div> 32 <div id="ppl_results" class="search-results"></div> 33 </div> 38 <div class="dcf-col-100% dcf-col-33%-end@md dcf-col-50%-end@lg results-group" id="directory_results"> 39 <div class="dcf-tabs"> 40 <h2>Directory Results</h2> 41 <ul> 42 <li><a href="#people_results">People</a></li> 43 <li><a href="#dept_results" class="dept-results-tab">Departments</a></li> 44 </ul> 45 <div id="people_results"></div> changed this line in version 12 of the diff
@rdee2 - All requests should be done, ready for review
Looks good, @JSTUREK8
mentioned in commit ba86cd88
mentioned in issue #8 (closed)