Skip to content
Snippets Groups Projects

Initial conversion from 4.1 to 5.0

Merged Ryan Dee requested to merge rdee2/UNL_Search:5.0 into master
1 unresolved thread
  • Update existing node modules
  • Add Autoprefixer, cssnano, PostCSS
  • Convert Less to Sass
  • Update 4.1 styles to 5.0
  • Update markup to use utility classes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
7 };
8
9 window.__gcse = {
10 parsetags: 'explicit',
11 callback: window.searchInit
12 };
13
14 $('<script>', {
15 src: '<?php echo $googleLoaderUrl ?>',
16 async: 'async',
17 defer: 'defer',
18 type: 'text/javascript'
19 }).appendTo($('body'));
20
21 var $localCss = $('<link>', {
22 'href': './css/search-google.css?v=20170404'
  • The less files need to be restored so that 4.1 is supported

  • So we need like LESS for 4.1 ---> css/search-google.css and SCSS for 5.0 ---> css/search-google-5-0.css

    or similar

  • The old 4.1 css doesn't have to remain LESS, it can be converted - but we need a 4.1 CSS file and a 5.0 CSS file

  • Ryan Dee added 4 commits

    added 4 commits

    • ec10f4db - Reinstall Less node modules for 4.1
    • 50719aea - Restore Less files for 4.1
    • 986beebb - Update 4.1- and 5.0-specific tasks in Gruntfile
    • 1822826a - Add 5.0-specific stylesheets in PHP files

    Compare with previous version

  • Eric Rasmussen mentioned in commit a5a247ed

    mentioned in commit a5a247ed

  • Please register or sign in to reply
    Loading