Skip to content
Snippets Groups Projects

Figures

Merged Ryan Dee requested to merge figures into develop

Add clear-top class to figures affected by new normalize margins

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    The recent update to Normalize has added margins to figures. After some discussion with Kevin and Michael, we decided that rather than adding a .clear-top class to each figure, it would be OK in most cases to remove the figure elements and simply leave the image.

130 130 <div class="wdn-col">
131 131 <div class="wdn-grid-set">
132 132 <div class="bp2-wdn-col-five-sixths bp3-wdn-col-full">
133 <figure class="wdn-frame"><img src="images/malfese-mri.jpg" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." /></figure>
133 <img src="images/malfese-mri.jpg" class="wdn-frame" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." />
  • I almost think that these could benefit from the

    element with a
    that explains what is going on. I think it could help to sell the "research" that is being pictured. I'm not sure if that falls in line with the goals of the page, but when I look at the images on this page, I wish I knew more about them.

  • 130 130 <div class="wdn-col">
    131 131 <div class="wdn-grid-set">
    132 132 <div class="bp2-wdn-col-five-sixths bp3-wdn-col-full">
    133 <figure class="wdn-frame"><img src="images/malfese-mri.jpg" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." /></figure>
    133 <img src="images/malfese-mri.jpg" class="wdn-frame" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." />
    • I guess I'm not sure. When I look at the prospective student page, it has a very similar layout, but I don't think those images would benefit much from a

      . What are your thoughts?

  • 130 130 <div class="wdn-col">
    131 131 <div class="wdn-grid-set">
    132 132 <div class="bp2-wdn-col-five-sixths bp3-wdn-col-full">
    133 <figure class="wdn-frame"><img src="images/malfese-mri.jpg" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." /></figure>
    133 <img src="images/malfese-mri.jpg" class="wdn-frame" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." />
    • Well, okay. I'm re-reading my comments and found that some text was stripped. Insert <figure> and <figcaption> where needed. "I almost think that these could benefit from the <figcaption> element"

  • Ryan Dee
    Ryan Dee @rdee2 started a thread on the diff
  • 130 130 <div class="wdn-col">
    131 131 <div class="wdn-grid-set">
    132 132 <div class="bp2-wdn-col-five-sixths bp3-wdn-col-full">
    133 <figure class="wdn-frame"><img src="images/malfese-mri.jpg" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." /></figure>
    133 <img src="images/malfese-mri.jpg" class="wdn-frame" alt="Dennis L. Molfese peeks through the opening of the New MRI machine for Center for Brain, Biology, and Behavior (CB3) being moved into East Stadium construction." />
    • Author Maintainer

      These top level pages will be redesigned again soon. We just needed to get them moved into 4.0 by May 19, but we're currently working on redeveloping the content for these pages. I think the new content might help to determine how it should structured.

  • Author Maintainer

    I guessed (correctly) what you meant.

  • Please register or sign in to reply
    Loading