Skip to content
Snippets Groups Projects

Increase JPG/PNG size to 800px

Merged Increase JPG/PNG size to 800px
feature/issue-5 into develop
Merged Tyler R Lemburg requested to merge feature/issue-5 into develop

200px height was too small and when you expand it gets blurry.

Solves #5 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/Models/Lockup.php
231 231
232 232 $return_var = NULL;
233 233
234 exec('inkscape -h200 --export-png=' . $new_png . ' ' . $starting_svg . ' 2>&1', $backend_output, $return_var);
234 exec('inkscape -h800 --export-png=' . $new_png . ' ' . $starting_svg . ' 2>&1', $backend_output, $return_var);
  • Michael Fairchild
    Michael Fairchild @s-mfairch4

    Not really related to this specific PR, but I would look into escaping the parameters, $new_png and $starting_svg. It looks like the structure of $new_png does not allow for an injection attack, but $new_png is more vulnerable. While $new_png is being somewhat escaped by getOrganizationFilename(), there may still be room to improve. I'd suggest escapeshellarg() just to make sure. The same goes for all calls to exec.

  • Tyler R Lemburg
    Tyler R Lemburg @s-tlembur1 started a thread on the diff
    • src/Models/Lockup.php
    231 231
    232 232 $return_var = NULL;
    233 233
    234 exec('inkscape -h200 --export-png=' . $new_png . ' ' . $starting_svg . ' 2>&1', $backend_output, $return_var);
    234 exec('inkscape -h800 --export-png=' . $new_png . ' ' . $starting_svg . ' 2>&1', $backend_output, $return_var);
  • Michael Fairchild Status changed to merged

    Status changed to merged

  • Michael Fairchild mentioned in commit a11e7381

    mentioned in commit a11e7381

    • Please register or sign in to reply