Skip to content
Snippets Groups Projects

WDN 4.0 Theme

Merged Kevin Abel requested to merge four into master

Provides new visual styles for the search box and results from directory and Google custom search.

Also lays the ground work to support embedding the results into an iframe. This will allow templated pages to show search results without having to leave the page they are searching from.

Merge request reports

Merged by avatar (Mar 20, 2025 9:06am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
233 233
234 234 .embed & {
235 235 width: 60%;
236
237 .result-head {
238 border-right: 1px solid @ui10;
  • Kevin Abel
    Kevin Abel @kabel2 started a thread on commit 6f5445f9
  • 233 233
    234 234 .embed & {
    235 235 width: 60%;
    236
    237 .result-head {
    238 border-right: 1px solid @ui10;
  • Michael Fairchild
  • 233 233
    234 234 .embed & {
    235 235 width: 60%;
    236
    237 .result-head {
    238 border-right: 1px solid @ui10;
  • Kevin Abel
    Kevin Abel @kabel2 started a thread on commit 6f5445f9
  • 233 233
    234 234 .embed & {
    235 235 width: 60%;
    236
    237 .result-head {
    238 border-right: 1px solid @ui10;
    • Author Contributor

      I think the latter is the case, but you'd have to check with Dee. I don't think the usage plan for them has been fully established.

  • Michael Fairchild
  • 72 81
    73 82 if (isset($_GET['cx'])) {
    74 83 // Use their custom search engine instead of the linked one.
    75 $context = '"'.htmlentities($_GET['cx'], ENT_QUOTES).'"';
    84 $context = $_GET['cx'];
  • Kevin Abel
    Kevin Abel @kabel2 started a thread on commit b78b5f23
  • 72 81
    73 82 if (isset($_GET['cx'])) {
    74 83 // Use their custom search engine instead of the linked one.
    75 $context = '"'.htmlentities($_GET['cx'], ENT_QUOTES).'"';
    84 $context = $_GET['cx'];
  • This looks fine to me. Some questions:

    • How would you like me to test this?
    • Should this be merged now, or should we wait until we get closer to the deadline? If I recall correctly, we can launch this before the deadline
    • Would this break/affect sites that search via 3.1 or 3.0?
  • Author Contributor
    1. Checkout, make, copy config file (optionally setting UNL_Search::$mode), try to run search from local server
    2. I would say merge as soon as we're ready
    3. No. The older template versions will continue to submit to the search application as is. They'll just be presented with a fancier interface.
  • Its working for me: http://ucommfairchild.unl.edu/search/www/

    Some things that I would like to see but might be better in a different merge request

    • a test suite
    • a vagrant file

    Improving the readme with instructions on how to get this up and running should be included with this merge request.

  • Author Contributor

    Great. Yes, a test suite would be nice, but it's much easier to just to manually test at this point.

    The README has been updated, briefly.

  • I just noticed that pa11y is reporting two errors on the search page, and a lot more errors after a search has been preformed. I'm guessing this is a problem with google that we have little control over?

  • Author Contributor

    I'll add some JS to fix some of the google provided markup. I need to talk to Dee about the color failures in the results.

  • Cool, I will wait to merge until we have that sorted out.

  • Author Contributor

    Latest commit should take care of everything that is wrong.

  • Still seeing some errors with "no name and/or ID attribute" after searching.

  • Author Contributor

    That is Google "template" content that is never visible to the user or the screen-reading API (display:none). Unfortunately there is no simple way to remove it.

  • That is unfortunate...

  • Please register or sign in to reply
    Loading